-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add onCreateNode params and example #27503
Merged
LekoArts
merged 4 commits into
gatsbyjs:master
from
sampittko:docs/add-oncreatenode-params-and-example
Nov 23, 2022
Merged
docs: add onCreateNode params and example #27503
LekoArts
merged 4 commits into
gatsbyjs:master
from
sampittko:docs/add-oncreatenode-params-and-example
Nov 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Oct 16, 2020
sampittko
changed the title
docs: add onCreateNode params and example (#12665)
docs: add onCreateNode params and example
Oct 16, 2020
LekoArts
added
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Oct 19, 2020
LekoArts
reviewed
Oct 19, 2020
packages/gatsby/index.d.ts
Outdated
* createNodeField({ | ||
* node, | ||
* name: `slug`, | ||
* value: polishSlug(`/blog/${postSlug}/`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is polishSlug
coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is function from my project, I forgot to remove it for the example, will do so now
@LekoArts is it ready for merge? |
LekoArts
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: documentation
An issue or pull request for improving or updating Gatsby's documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As stated in #12665, there is a need to add both parameters specific to the APIs and examples of using the APIs. This PR adds onCreateNode params and also example of its use.
Documentation
@gatsbyjs/documentation
Related Issues
#12665