fix(plugin-manifest): Allow for all valid WebAppManifest properties #27951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evious unmerged PR
gatsbot
bot
added
the
status: triage needed
|
This should be good. I'll handle changing how defaults are handled in another PR so we can get this fix out ASAP. |
pvdz
previously approved these changes
Nov 10, 2020
| @@ -47,4 +47,4 @@ | |||
| "engines": { | |||
| "node": ">=10.13.0" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
prettier should fix this (you could tune your editor ;) )
There was a problem hiding this comment.
(won't show up in discussions but the line ending is missing here)
mxstbr
previously approved these changes
Nov 11, 2020
|
(ran formatter) |
ediblecode
reviewed
Nov 11, 2020
ediblecode
reviewed
Nov 11, 2020
ediblecode
reviewed
Nov 11, 2020
mxstbr
added
the
bot: merge on green
|
This is pending a review from docs before the bot will merge. |
vladar
removed
the
status: triage needed
vladar
pushed a commit
that referenced
this pull request
Nov 16, 2020
…27951) * bring in complete(albeit outdated) WebAppManifest validation frrom previous unmerged PR * Cleanup Gatsby Plugin Options * update validation to match recent spec changes * update compatible gatsby version * reomve unused service worker object and fix numberic string * lint * add details from suplementry spec * final return * Prettify Co-authored-by: Max Stoiber <contact@mxstbr.com> (cherry picked from commit 88b990a)
vladar
added a commit
that referenced
this pull request
Nov 17, 2020
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current Plugin Options Validator for
gatsby-plugin-manifestis very incomplete. This PR implements a spec compliant validator.Documentation
I've added a not to docs about validation and the version of the spec it implements.
##TODO:
This is copied form the previous PR...testing and updates are needed.
Update to the latest spec - https://www.w3.org/TR/2020/WD-appmanifest-20201019/
Significant updates can now be made to how the plugin handles defaults, these can be done here or in a new PR.add Docs about feat(gatsby): add opt out flag SKIP_PLUGIN_OPTION_VALIDATION to bypass validation #27885Related Issues
fixes #27927