fix(gatsby): fix race condition in cache lock #28097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
type: chore
and removed
status: triage needed
pvdz
added
the
bot: merge on green
pvdz
removed
the
bot: merge on green
pvdz
changed the title
pvdz
changed the title
pvdz
added
type: bug
vladar
approved these changes
Nov 17, 2020
This was referenced Jul 22, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition by reserving the lock sync, rather than doing it in the
.then()callback. Doing it in the callback was causing a race condition because it allowed other lock requests to also be granted in the mean time.*raises fist*Also adds a try/catch around a JSON.parse call to show the complete output of what is being parsed in case we need to debug this again next time.