feat(gatsby): invite people with long develop bundling times to try the lazy dev js bundling feature #28116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: dev tooling
and removed
status: triage needed
Co-authored-by: Dustin Schau <DSchau@users.noreply.github.com>
KyleAMathews
changed the title
sidharthachatterjee
approved these changes
Nov 17, 2020
sidharthachatterjee
added
the
bot: merge on green
KyleAMathews
commented
Nov 17, 2020
| @@ -26,7 +26,7 @@ export function showExperimentNoticeAfterTimeout( | |||
| } | |||
|
|
|||
| const noticeTimeout = setTimeout(() => { | |||
| reporter.info(noticeText) | |||
| reporter.info(`\n\n${noticeText}\n\n`) | |||
There was a problem hiding this comment.
@pieh a little spacing around the messages makes them stand out better. Without it they seemed lost in the logs
This was referenced Jul 22, 2022
This was referenced Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It checks if the develop activity is over 20 seconds and then shows a message in the console.