Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): get-page-data should timeout gracefully #28131

Merged
merged 3 commits into from
Nov 19, 2020

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Nov 17, 2020

Description

This PR adds a timeout and retries to getPageData utility introduced in #27939
Also adds missing test coverage.

All credits for this PR go to @pieh 😄

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
@pieh pieh force-pushed the vladar/get-page-data-timeout branch from 81b2d6e to 2be1f89 Compare November 19, 2020 00:33
@vladar vladar marked this pull request as ready for review November 19, 2020 09:37
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in - less edges cases is always better ;)

@pieh pieh added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 19, 2020
@gatsbybot gatsbybot merged commit c517b60 into master Nov 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the vladar/get-page-data-timeout branch November 19, 2020 10:32
vladar added a commit that referenced this pull request Nov 19, 2020
* fix(gatsby): get-page-data should timeout gracefully

* lower timeout interval, add retries, make timeout configurable, add more tests

* Update packages/gatsby/src/utils/__tests__/get-page-data.ts

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit c517b60)
pieh pushed a commit that referenced this pull request Nov 19, 2020
* fix(gatsby): get-page-data should timeout gracefully

* lower timeout interval, add retries, make timeout configurable, add more tests

* Update packages/gatsby/src/utils/__tests__/get-page-data.ts

Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit c517b60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants