Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): rename env var for lazy dev bundling to make consistent with other experiments #28150

Merged
merged 1 commit into from
Nov 18, 2020
Merged

fix(gatsby): rename env var for lazy dev bundling to make consistent with other experiments #28150

merged 1 commit into from
Nov 18, 2020

Conversation

KyleAMathews
Copy link
Contributor

Also fix one instance of it.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2020
Anmol368
Anmol368 approved these changes Nov 18, 2020
View reviewed changes
Copy link

@Anmol368 Anmol368 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -14,7 +14,7 @@ import matchPaths from "$virtual/match-paths.json"
window.___emitter = emitter

@vladar vladar removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 18, 2020
vladar
vladar approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just suggested this here: #28147 (comment) 😄

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 18, 2020
@gatsbybot gatsbybot merged commit 9e3ceec into master Nov 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the rename-env branch November 18, 2020 05:51
@kaocher82 kaocher82 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jul 22, 2022
Open
This was referenced Jul 22, 2022
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Jul 23, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

@Anmol368 Anmol368 Anmol368 approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleAMathews @vladar @Anmol368 @gatsbybot