Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): make dev ssr bundling lazy (#28149) #28247

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Nov 23, 2020

Backporting #28149 to the release branch

(cherry picked from commit 70b81a6)

* feat(gatsby): make dev ssr bundling lazy

* fix tests

* fix race condition

* typescript 😅

* await getPageData to ensure it's been created before SSRing

* instance isn't set in SSR

* Fix a few more instances of this env var

* Avoid setting anything for experimental features

Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
(cherry picked from commit 70b81a6)
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 23, 2020
@vladar vladar added type: cherry and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 23, 2020
@vladar vladar merged commit 2dd2767 into release/2.27 Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the backport-28149 branch November 23, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants