feat(gatsby-plugin-image): Add extra props to GatsbyImage #28520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: media
ascorbic
force-pushed
the
feat/image-props
branch
from
b6a089c to
a328136
Compare
axe312ger
previously requested changes
Dec 9, 2020
sidharthachatterjee
dismissed
axe312ger’s stale review
Seems like no change is necessary!
sidharthachatterjee
approved these changes
Dec 10, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several props that were previously included in gatsby-image. I'm not 100% sure whether we should include all of them, particularly the ones that can be set using CSS. The additions are:
imgStyle: passed to the<img>tagimgClassName: passed to the<img>tagobjectFit: Added toimgStyleobjectPosition: Added toimgStylebackgroundColor: added tostyle, which is passed to the wrapper. This is not the same as thebackgroundColorthat comes from the resolver, which is applied to the placeholder, so disappears when the main image has loaded. This one is applied to the wrapper, so will remain after loading and can be used for transparent images for example.