Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): Include default transform options for webp #28620

Merged
merged 2 commits into from
Dec 15, 2020
Merged

fix(gatsby-plugin-sharp): Include default transform options for webp #28620

merged 2 commits into from
Dec 15, 2020

Conversation

ascorbic
Copy link
Contributor

Fixes a bug where default crop options were not being passed to the webp jobs, leading to differing crop results.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 15, 2020
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 15, 2020
pvdz
pvdz previously approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, may want to make it consistent

packages/gatsby-plugin-sharp/src/image-data.ts Outdated Show resolved Hide resolved
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 15, 2020
@ascorbic ascorbic requested a review from pvdz December 15, 2020 11:29
@ascorbic ascorbic merged commit 1c750b6 into master Dec 15, 2020
@ascorbic ascorbic deleted the fix/webp-transform-options branch December 15, 2020 11:33
@LekoArts LekoArts mentioned this pull request Dec 15, 2020
Merged
LekoArts pushed a commit that referenced this pull request Dec 15, 2020
@ascorbic @LekoArts
fix(gatsby-plugin-sharp): Include default transform options for webp (#…
97e0250 
…28620)

* fix(gatsby-plugin-sharp): Include default transform options for webp

* SNapshots

(cherry picked from commit 1c750b6)
LekoArts added a commit that referenced this pull request Dec 15, 2020
@LekoArts @ascorbic
fix(gatsby-plugin-sharp): Include default transform options for webp (#…
7f43c3b 
…28620) (#28629)

* fix(gatsby-plugin-sharp): Include default transform options for webp

* SNapshots

(cherry picked from commit 1c750b6)

Co-authored-by: Matt Kane <matt@gatsbyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvdz pvdz pvdz approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ascorbic @pvdz