test(e2e-development-runtime): add tests for loading indicator behavior #28700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: query on demand*
and removed
status: triage needed
pieh
force-pushed
the
qod/e2e-loading-indicator
branch
from
c3a46bd to
4a08694
Compare
pieh
force-pushed
the
qod/e2e-loading-indicator
branch
from
4a08694 to
239d930
Compare
pieh
commented
Feb 23, 2021
KyleAMathews
approved these changes
Feb 23, 2021
|
Can this be backported to v2? I want to backport the hydration fixes so people using DEV_SSR on v2 get that so it'd be nice to have this test too if possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add e2e tests skipped in #28562 (due to our outdated at a time cypress version didn't support shadow dom). #28580 updated cypress, so we can add loading indicator tests
Related Issues
[ch21014]