chore(gatsby): enable query on demand (and lazy images) by default for local development #28787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ures become defaults
… local development
gatsbot
bot
added
the
status: triage needed
pieh
commented
Dec 29, 2020
Comment on lines
+45
to
+46
| process.env.PRESERVE_FILE_DOWNLOAD_CACHE = `true` | ||
| process.env.PRESERVE_WEBPACK_CACHE = `true` |
There was a problem hiding this comment.
This is just "random" thing I spotted when looking for qod related changes I needed - we added those to FAST_DEV config flag but not to GATSBY_EXPERIMENTAL_FAST_DEV env var route - I can drop those from here, but it would be weird for FAST_DEV to only map to DEV_SSR 🤷
pieh
commented
Dec 29, 2020
Comment on lines
+207
to
+209
| if (message.length > 0) { | ||
| message += `\n` | ||
| } |
There was a problem hiding this comment.
This was sometimes causing \n message without any text (yikes)
pieh
commented
Dec 29, 2020
Comment on lines
-88
to
-90
| "message": " | ||
|
|
||
| We're shipping new features! For final testing, we're rolling them out first to a small % of Gatsby users |
There was a problem hiding this comment.
Result of adding checks before appending newlines to message in handle-flags.ts - it should no longer have "ghost" empty lines in front of messages
…anymore - those are defaults
pieh
removed
the
status: triage needed
pieh
commented
Dec 29, 2020
vladar
reviewed
Dec 29, 2020
vladar
reviewed
Dec 29, 2020
Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
vladar
previously approved these changes
Dec 29, 2020
vladar
approved these changes
Dec 29, 2020
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…r local development (gatsbyjs#28787) * feat(flags): add LOCKED_IN mode for flags for cases where opt-in features become defaults * feat(gatsby): enable query on demand (and lazy images) by default for local development * fix "lint" * chore(telemetry): don't track usage of query on demand / lazy images anymore - those are defaults * use plain false instead of weird Symbol do opt out of telemetry tracking * Update packages/gatsby/src/utils/handle-flags.ts Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com> * update snapshots Co-authored-by: Vladimir Razuvaev <vladimir.razuvaev@gmail.com>
This was referenced Nov 5, 2022
This was referenced Nov 5, 2022
This was referenced Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR "graduates" query on demand mode to default in non-CI environment.
Main change here is adding support for
LOCKED_INsetting for flags - this is done mainly to display more meaningful message in terminal. Removing the flag from the list would result in "unknown" flag message that could be confusing.