Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): Hydrate in development when the page was server rendered #29016

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Jan 13, 2021

This is so we error with message when there's a mismatch between SSRed html and client-side HTML. Hydration errors are a common problem in production so we want to highlight then in dev.

With this PR, hydration problems now error like this in dev:

Screen Shot 2021-01-13 at 1 47 59 PM

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 13, 2021
@KyleAMathews KyleAMathews added topic: dev tooling type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement. and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer topic: dev tooling labels Jan 13, 2021
@KyleAMathews KyleAMathews merged commit bf6f264 into master Jan 14, 2021
@KyleAMathews KyleAMathews deleted the hydrate-ssr branch January 14, 2021 15:55
vladar pushed a commit that referenced this pull request Jan 16, 2021
gatsbybot pushed a commit that referenced this pull request Jan 16, 2021
(cherry picked from commit bf6f264)

Co-authored-by: Kyle Mathews <mathews.kyle@gmail.com>
@vladar
Copy link
Contributor

vladar commented Jan 16, 2021

Published in gatsby@2.30.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature or enhancement Issue that is not a bug and requests the addition of a new feature or enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants