-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby): Hydrate in development when the page was server rendered #29016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 13, 2021
KyleAMathews
added
topic: dev tooling
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
topic: dev tooling
labels
Jan 13, 2021
pvdz
approved these changes
Jan 14, 2021
vladar
pushed a commit
that referenced
this pull request
Jan 16, 2021
(cherry picked from commit bf6f264)
gatsbybot
pushed a commit
that referenced
this pull request
Jan 16, 2021
Published in |
This was referenced Jan 19, 2021
Open
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature or enhancement
Issue that is not a bug and requests the addition of a new feature or enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we error with message when there's a mismatch between SSRed html and client-side HTML. Hydration errors are a common problem in production so we want to highlight then in dev.
With this PR, hydration problems now error like this in dev: