Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to skip cache persistence #29047

Merged
merged 1 commit into from
Jan 18, 2021
Merged

allow to skip cache persistence #29047

merged 1 commit into from
Jan 18, 2021

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jan 15, 2021

Description

This is a solution to be able to temporarily disable cache persistance in case of hitting fatal process crash:

../src/node_buffer.cc:451:v8::MaybeLocal<v8::Object> node::Buffer::New(node::Environment*, char*, size_t, bool): Assertion `length <= kMaxLength' failed.
1: 0xa9d570 node::Abort() [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
2: 0xa9d5f7 [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
3: 0xa7e022 [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
4: 0xb1190a [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
5: 0xc7491c [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
6: 0xc76727 v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
7: 0x145cef9 [/opt/hostedtoolcache/node/13.8.0/x64/bin/node]
Aborted (core dumped)
error Command failed with exit code 134.

Gatsby currently doesn't provide a way for users / sites to not hit the problem and this is sometimes blocking new deploys. This is related to #29039 which allow sites to continue to use cache but is much more hands-on approach that might not be applicable to quickly workaround the problem (specifically when urgent deploy need to happen scenarios). Those 2 are not mutually exclussive - they both have their place. This PR is meant to immediately unblock deploys (with caveat of not being able to make use of cached work). Other PR is meant to give control over how we shard nodes to also workaround the problem, but without serious performance implicaiton of always using COLD builds.

Related Issues

[ch22889]
#23627

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 15, 2021
@pieh pieh removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 15, 2021
@gatsbyjs gatsbyjs deleted a comment from shortcut-integration bot Jan 15, 2021
@pieh pieh merged commit bd5b5f7 into master Jan 18, 2021
@pieh pieh deleted the feat/cache/disable-persistence branch January 18, 2021 10:28
This was referenced Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants