-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to skip cache persistence #29047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 15, 2021
pieh
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Jan 15, 2021
pvdz
approved these changes
Jan 15, 2021
This was referenced Jan 19, 2021
Open
This was referenced Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a solution to be able to temporarily disable cache persistance in case of hitting fatal process crash:
Gatsby currently doesn't provide a way for users / sites to not hit the problem and this is sometimes blocking new deploys. This is related to #29039 which allow sites to continue to use cache but is much more hands-on approach that might not be applicable to quickly workaround the problem (specifically when urgent deploy need to happen scenarios). Those 2 are not mutually exclussive - they both have their place. This PR is meant to immediately unblock deploys (with caveat of not being able to make use of cached work). Other PR is meant to give control over how we shard nodes to also workaround the problem, but without serious performance implicaiton of always using COLD builds.
Related Issues
[ch22889]
#23627