refactor(gatsby-transformer-remark): Refactors out Bluebird usage in transformer-remark #29638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
ascorbic
reviewed
Feb 25, 2021
ascorbic
changed the title
|
Hi. Thanks for this. This is failing tests right now. I think this is because of an error in the code. I've added a suggestion. Could you take a look and see if it fixes it? You can run |
ascorbic
added
topic: remark/mdx
|
Updated with your suggestion and merged with master. I don't think the still-failing tests are related to this change? |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…transformer-remark (gatsbyjs#29638) Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor cleanup, noticed the usage of Bluebird's
Promise.eachwas unnecessary when reading through the source.