-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): upgrade socket.io #29765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Feb 25, 2021
ascorbic
reviewed
Feb 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ESM import syntax has changed in v3: https://socket.io/docs/v3/server-initialization/index.html
ascorbic
approved these changes
Feb 25, 2021
ascorbic
added
type: chore
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Feb 25, 2021
ascorbic
pushed a commit
that referenced
this pull request
Feb 25, 2021
* chore(gatsby): upgrade socket.io * fix types (cherry picked from commit 3ab492c)
ascorbic
pushed a commit
that referenced
this pull request
Feb 25, 2021
This was referenced Feb 25, 2021
This was referenced Mar 7, 2021
This was referenced May 5, 2021
This was referenced Oct 31, 2022
This was referenced Dec 6, 2023
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrading socket.io to latest version - subset of #29699