-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create multiple layouts from same components with different context #3039
fix: create multiple layouts from same components with different context #3039
Conversation
The bug appears in pages-writer.js:89 , we need to use the layout id as identifier instead of his path fixes #3025
Deploy preview ready! Built with commit 0f900fe |
Deploy preview ready! Built with commit e3734d3 |
this is great! thanks for taking care of the PR @abumalick |
Ah cool! Yeah, this makes a lot of sense. Thanks for the investigative work + PR! |
Hiya @abumalick! 👋 This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here. Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! 💪💜 |
fix: create multiple layouts from same components with different context
As explained in #3025 : when we try to create multiple layouts with different context from one component, we notice that we get only the last layout created.
The bug appears in
pages-writer.js:89
, we have to use the layout id as identifier instead of his pathThanks to @yachaka for pointing out the source of the bug
fixes #3025