fix(gatsby-plugin-netlify-cms): Don't use StaticQueryMapper #30599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Netlify CMS plugin is spinning an extra webpack instance with almost every plugin from gatsby. Reusing the `StaticQueryMapper` plugin caused issues given how it's dealing with a Gatsby state. Fixes gatsbyjs#29951 This commit also: - removes `cssTests` which wasn't used anymore - adds a clear TODO for how to get `excludeAssets` to be taken into account again
gatsbot
bot
added
the
status: triage needed
ridem
changed the title
|
I can confirm that this fixed the issue. |
wardpeet
approved these changes
Apr 2, 2021
LekoArts
removed
the
status: triage needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure that the
StaticQueryMapperplugin isn't used by the webpack instance ofgatsby-plugin-netlify-cms.The Netlify CMS plugin is spinning an extra webpack instance with almost every plugin from gatsby. Reusing the
StaticQueryMapperplugin caused issues given how it's dealing with a Gatsby state.This PR also:
cssTestsvariable which wasn't used anymoreexcludeAssetsto be taken into account again. A webpack plugin had been removed to make this package compatible with webpack 5, but the functionality hasn't been put back. (Edit: this means that sincegatsby-plugin-netlify-cmswas made compatible with webpack 5, all of the CSS that is imported is included in its HTML SPA template. Maybe there's a bug report out there already, but that means there could be CSS from the website polluting the CSS of the admin page)Related Issues
Fixes #29951