Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Conditionally test ESLint rules #31258

Merged
merged 1 commit into from
May 5, 2021
Merged

test: Conditionally test ESLint rules #31258

merged 1 commit into from
May 5, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented May 5, 2021

Description

While looking at logs of #31061 I was pretty annoyed by the repeated logs of ESLint. This PR only adds the invalid syntax when the test is run + it ignores two files that we don't test and can safely ignore.

@LekoArts LekoArts added the topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot label May 5, 2021
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2021
@LekoArts LekoArts removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 5, 2021
@pieh pieh merged commit f39b153 into master May 5, 2021
@pieh pieh deleted the silence-ci-eslint branch May 5, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants