-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-google-analytics): enable core webvitals tracking #31665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
May 31, 2021
wardpeet
added
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
topic: plugins-analytics
Various analytics plugins like gatsby-plugin-google-analytics
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
May 31, 2021
wardpeet
commented
Jun 2, 2021
wardpeet
commented
Jun 2, 2021
@@ -40,4 +40,5 @@ exports.pluginOptionsSchema = ({ Joi }) => | |||
.description( | |||
`Name of the event that is triggered on every Gatsby route change.` | |||
), | |||
disableWebVitalsTracking: Joi.boolean().default(true), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will make it a default in the next major. I want to do some more updates in a follow up PR
pieh
reviewed
Jun 14, 2021
Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh
reviewed
Jun 15, 2021
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: frontend
Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
topic: plugins-analytics
Various analytics plugins like gatsby-plugin-google-analytics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Web Vitals to gatsby-plugin-google-analytics and gatsby-plugin-google-tagmanager. I skipped gtag as the plugin needs a bit more work to get everything going.
We use the web-vitals package to request this data a breeze. Following this guide for implementation https://github.com/GoogleChrome/web-vitals#send-the-results-to-google-analytics
Documentation
Updated readmes files
Related Issues
[ch27058]