Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-google-analytics): enable core webvitals tracking #31665

Merged
merged 28 commits into from
Jun 15, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented May 31, 2021

Description

Add Web Vitals to gatsby-plugin-google-analytics and gatsby-plugin-google-tagmanager. I skipped gtag as the plugin needs a bit more work to get everything going.

We use the web-vitals package to request this data a breeze. Following this guide for implementation https://github.com/GoogleChrome/web-vitals#send-the-results-to-google-analytics

Documentation

Updated readmes files

Related Issues

[ch27058]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 31, 2021
@wardpeet wardpeet added topic: frontend Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation) topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 31, 2021
@wardpeet wardpeet marked this pull request as ready for review June 1, 2021 15:41
@@ -40,4 +40,5 @@ exports.pluginOptionsSchema = ({ Joi }) =>
.description(
`Name of the event that is triggered on every Gatsby route change.`
),
disableWebVitalsTracking: Joi.boolean().default(true),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will make it a default in the next major. I want to do some more updates in a follow up PR

@pieh pieh self-assigned this Jun 14, 2021
@wardpeet wardpeet marked this pull request as draft June 15, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: frontend Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation) topic: plugins-analytics Various analytics plugins like gatsby-plugin-google-analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants