Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-drupal): Disable caching + add http/2 agent (#32012) #32038

Merged
merged 1 commit into from
Jun 22, 2021

Commits on Jun 22, 2021

  1. feat(gatsby-source-drupal): Disable caching + add http/2 agent (#32012)

    * feat(gatsby-source-drupal): Force revalidation on Drupal API requests
    
    Talking to Gatsby/Drupal users — most set long max-age for the Drupal cache to
    keep their edge http cache as fresh as possible as Drupal can directly purge
    its edge http cache.
    
    But this has the unfortunate side-effect with the recent http client change in
    #31514 that API calls aren't
    revalidated. Meaning that a user could change some content in Drupal and not
    see those updates in their Gatsby site until the Drupal cache expires in the
    Gatsby cache.
    
    This PR removes the `cache-control` header from Drupal API responses so that
    we only can use `etag` for caching which forces revalidation on every request.
    
    * Remove debugging line
    
    * Add http/2 agent
    
    * Disable cache — it's slower than refetch with revalidation
    
    * push don't concat
    
    * consistent return
    
    * Fix statusCode check for got
    
    * Actually this was correct...
    
    * Actually use http/2
    
    (cherry picked from commit 113e43e)
    
    # Conflicts:
    #	packages/gatsby-source-drupal/package.json
    KyleAMathews authored and vladar committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    973e1d3 View commit details
    Browse the repository at this point in the history