Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross-origin requests in development mode #3299

Merged

Conversation

m-allanson
Copy link
Contributor

Allow cross-origin requests in gatsby develop. This should avoid CORS errors when using the --host flag.

Hopefully this helps with working out #2956.

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit f2a6085

https://deploy-preview-3299--gatsbygram.netlify.com

@KyleAMathews KyleAMathews merged commit 4285d31 into gatsbyjs:master Dec 21, 2017
@KyleAMathews
Copy link
Contributor

Thanks! Good call 👍

@m-allanson m-allanson deleted the topics/develop-cors-headers branch December 21, 2017 17:29
@m-allanson
Copy link
Contributor Author

No problem!

Hmm thinking about it, should gatsby serve also allow cross-origin requests?

@KyleAMathews
Copy link
Contributor

@m-allanson yeah!

@m-allanson
Copy link
Contributor Author

Actually scratch that.. Using the example typefaces-vs-fontFace repo I can't replicate @benforshey's gatsby serve / CORS issue from #2956 (comment), so I'll leave the serve command alone for now.

@KyleAMathews
Copy link
Contributor

Ah yeah we use https://www.npmjs.com/package/serve which perhaps handles CORS already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants