feat(gatsby-transformer-remark): use subplugin annotation to use automatic subplugin module loading #33039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matic subplugin module loading
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: remark/mdx
vladar
reviewed
Sep 6, 2021
Comment on lines
+43
to
+44
| const resolvedPlugin = | ||
| _CFLAGS_.GATSBY_MAJOR === `4` ? plugin.module : require(plugin.resolve) |
There was a problem hiding this comment.
So the old behavior will be incompatible with v4 and will be a breaking change? Did we consider keeping it compatible? I am fine with both but if it will be a breaking change we should probably add a note in #32860
There was a problem hiding this comment.
require(plugin.resolve) will continue to work in V4, but it will be undesirable to use it due to bundling problems with dynamic imports and using .subPlugins will be recomended. Not sure if there is nice way to "deprecate" old style here
vladar
added
the
bot: merge on green
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…matic subplugin module loading (gatsbyjs#33039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depend on #33030
Description
This moves
gatsby-transformer-remarkaway from requiring arbitrary modules inside plugin and instead relying onsubPluginshelper to automatically load those modules.Same as #33040 - just for
gatsby-plugin-mdxpackage