Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): reduce page-renderer-size #33051

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Sep 4, 2021

Description

Removes lodash from static-entry and changes webpack config to improve performance:

Tested it on blog-starter

  • Drops page-renderer from 827kb => 295kb (decrease of 64.33%)
  • Perf cold build 1.8s => 1.3s
  • Perf warm build (no change): 1s -> 0.5s

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 4, 2021
case `develop-html`:
case `build-html`:
return `development` // So we don't uglify the html bundle
return `production`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use production builds and just put the minimizer to false

@wardpeet wardpeet force-pushed the fix/reduce-page-renderer branch from b6659c4 to 9f40495 Compare September 4, 2021 16:08
@wardpeet wardpeet added topic: webpack/babel Webpack or babel type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: webpack/babel Webpack or babel type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants