Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-parcel-config): stabilize ts compilation parcel output #34943

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Feb 28, 2022

Description

Right now, because of parcel-bundler/parcel#5476 (comment) when you have .ts file only in local plugin, but not in the root of the repo the output is "messed up" - compiled files are in unexpected locations which means gatsby can't load proper gatsby-node file.

This PR looks to first add failing test case covering above and in next commit add "workoarund" (by adding customer namer plugin)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 28, 2022
@pieh pieh added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 28, 2022
@LekoArts
Copy link
Contributor

Do we not want to move this into our monorepo? Also Parcel wants us to use @gatsbyjs scope: https://parceljs.org/plugin-system/authoring-plugins/#naming

Base automatically changed from feat/ts-aot to master February 28, 2022 13:47
@pieh pieh force-pushed the feat/ts-aot-stable-output-structure branch from 650d365 to 78845d0 Compare February 28, 2022 14:22
@pieh
Copy link
Contributor Author

pieh commented Mar 1, 2022

Do we not want to move this into our monorepo? Also Parcel wants us to use @gatsbyjs scope: parceljs.org/plugin-system/authoring-plugins/#naming

For now I renamed package to be @gatsbyjs/ scoped and published and adjusted dependencies in this PR. Adding the package itself to monorepo would be follow up ( https://github.com/pieh/parcel-namer-relative-to-cwd is the current repo )

@LekoArts LekoArts changed the title chore: stabilize ts compilation parcel output chore(gatsby-parcel-config): stabilize ts compilation parcel output Mar 1, 2022
@LekoArts LekoArts merged commit f2bce35 into master Mar 1, 2022
@LekoArts LekoArts deleted the feat/ts-aot-stable-output-structure branch March 1, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants