-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-plugin-utils): enable tracedsvg #35328
Conversation
f24217f
to
9e273be
Compare
9e273be
to
080a40d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! :) What benefit does @gatsby/potrace
give us over the original package?
Just pitching here in support of this, our team is blocked heavily since the original package has the viral GPL license. Our clients can't move forward without assurance that all code we use is compliant with their particular license agreements |
I upgraded the license to GPL v3 (which is allowed by their License) and GPL v3 is compatible with MIT |
Amazing, I was wondering how that would work 👍 |
in Readme there is still noted v2:
// PR: gatsbyjs/node-potrace#1 |
(I assume this means LGPLv3, per this thread and https://github.com/gatsbyjs/node-potrace/blob/f182e9e/LICENSE) Lesser GPL isn't interoperable as it looks. The wording can be muddy as it wasn't written with scripting languages and package systems in mind. |
Description
Enable traced SVG for image cdn and convert all implementations to our own @gatsbyjs/potrace with GNU 3 License to be compatible with MIT.
I've updated all potrace usage