-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-source-wordpress): bring back defaults before image_cdn #35370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Apr 7, 2022
wardpeet
added
topic: source-wordpress
Related to Gatsby's integration with WordPress
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Apr 7, 2022
wardpeet
force-pushed
the
feat/image-regression
branch
from
April 8, 2022 12:29
93fd353
to
14274f2
Compare
TylerBarnes
requested changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for doing it! I think the only thing is we need to generate the plugin options MD file and then this is ready to merge
packages/gatsby-source-wordpress/src/steps/declare-plugin-options-schema.js
Show resolved
Hide resolved
packages/gatsby-source-wordpress/src/steps/source-nodes/create-nodes/process-node.js
Show resolved
Hide resolved
LekoArts
added
the
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
label
Apr 11, 2022
TylerBarnes
reviewed
Apr 14, 2022
packages/gatsby-plugin-utils/src/polyfill-remote-file/graphql/gatsby-image-resolver.ts
Outdated
Show resolved
Hide resolved
TylerBarnes
approved these changes
Apr 20, 2022
This was referenced Nov 27, 2023
This was referenced Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: source-plugins
Relates to the Gatsby source plugins (e.g. -filesystem)
topic: source-wordpress
Related to Gatsby's integration with WordPress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Image CDN we got some complains about Wordpress getting slower. This is mostly due AVIF and placeholder creation. I've looked at the previous commit and we're now opting out of AVIF when not using the Gatsby's cloud image service. Of course you can toggle it on.
Documentation
Related Issues