Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-link): modify relative links based on trailing slash option #35444

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Apr 18, 2022

Description

Modify relative links based on trailing slash option

Related Issues

Fixes #35419

[sc-49188]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 18, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert the whitespace changes? In the src/pages/index.js line 17 for example, or the empty line before the component. Or the empty line changes in the rewrite-link-path file

@LekoArts LekoArts added topic: frontend Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 19, 2022
Co-authored-by: Lennart <lekoarts@gmail.com>
@marvinjude marvinjude changed the title fix(gatsby-link): fix ending slash issue fix(gatsby-link): modify relative links based on trailing slash option Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: frontend Relates to frontend issues (e.g. reach/router, gatsby-link, page-loading, asset-loading, navigation)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailingSlash option isn't applied on client-side links when a relative path is specified
2 participants