-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gatsby): Make plugins
in PluginOptions
type optional
#36351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
label
Aug 10, 2022
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 10, 2022
LekoArts
removed
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 10, 2022
marvinjude
approved these changes
Aug 10, 2022
I think you want to extend |
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Aug 16, 2022
This was referenced Dec 26, 2022
This was referenced Dec 26, 2022
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: TypeScript
Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
So I've ran into this while I defined a
interface CustomPluginOptions extends PluginOptions
in a plugin. I extend thePluginOptions
from gatsby here so that I can use it in the gatsby-config and in the gatsby-node APIs.But with
plugins
being required TS complained that my plugin didn't defineplugins
.I know, we set this by default, but for using this type in 3rd party packages it's annoying