Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-script): Reach router import #36385

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Aug 15, 2022

Description

Import our Reach Router fork the same way we do in Gatsby Link. Originally used the other import because it appeared to not use the same module as Gatsby core otherwise.

Also adds Reach Router as a peer dependency.

Documentation

N/A

Related Issues

N/A

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 15, 2022
@tyhopp tyhopp marked this pull request as draft August 15, 2022 04:19
@tyhopp tyhopp removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 15, 2022
@LekoArts LekoArts added the topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) label Aug 15, 2022
@LekoArts LekoArts marked this pull request as ready for review August 15, 2022 07:39
@LekoArts LekoArts merged commit 4c752d1 into master Aug 15, 2022
@LekoArts LekoArts deleted the fix-gatsby-script-router-import branch August 15, 2022 07:39
marvinjude pushed a commit that referenced this pull request Aug 16, 2022
marvinjude pushed a commit that referenced this pull request Aug 16, 2022
(cherry picked from commit 4c752d1)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants