-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby): Prevent errors if Head
has root text node
#36402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Aug 17, 2022
marvinjude
added
topic: DX
Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Aug 17, 2022
marvinjude
changed the title
fix(gatsby): Dont break if Head has root text node(s)
fix(gatsby): Dont break if Aug 17, 2022
Head
has root text node(s)
marvinjude
changed the title
fix(gatsby): Dont break if
fix(gatsby): Dont break if Aug 17, 2022
Head
has root text node(s)Head
has root text node
marvinjude
changed the title
fix(gatsby): Dont break if
fix(gatsby): Prevent errors if Aug 17, 2022
Head
has root text nodeHead
has root text node
imjoshin
approved these changes
Aug 17, 2022
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced Nov 26, 2023
This was referenced May 15, 2024
This was referenced May 15, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent
Head
from breaking if it contains root level text (text node)Adding some text like "Break" above will throw errors on trying to access the
attribute
object on a text node since text nodes have no attribute keyThis fix is important for users using a CMS(like WordPress where the text they're trying to pass also contains invalid head elements and root level text(s)
Documentation
https://www.gatsbyjs.com/docs/reference/built-in-components/gatsby-head/
Related Issues
A user reported this issue on discord https://discord.com/channels/484383807575687178/537691356487876624/1009100830261129356