Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): Prevent errors if Head has root text node #36402

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

marvinjude
Copy link
Contributor

@marvinjude marvinjude commented Aug 17, 2022

Description

Prevent Head from breaking if it contains root level text (text node)

export const Head = () => (
  <>
    Break 
    <title>Head Export</title>
  </>
);

Adding some text like "Break" above will throw errors on trying to access the attribute object on a text node since text nodes have no attribute key

This fix is important for users using a CMS(like WordPress where the text they're trying to pass also contains invalid head elements and root level text(s)

Documentation

https://www.gatsbyjs.com/docs/reference/built-in-components/gatsby-head/

Related Issues

A user reported this issue on discord https://discord.com/channels/484383807575687178/537691356487876624/1009100830261129356

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 17, 2022
@marvinjude marvinjude added topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 17, 2022
@marvinjude marvinjude changed the title fix(gatsby): Dont break if Head has root text node(s) fix(gatsby): Dont break if Head has root text node(s) Aug 17, 2022
@marvinjude marvinjude changed the title fix(gatsby): Dont break if Head has root text node(s) fix(gatsby): Dont break if Head has root text node Aug 17, 2022
@marvinjude marvinjude changed the title fix(gatsby): Dont break if Head has root text node fix(gatsby): Prevent errors if Head has root text node Aug 17, 2022
@marvinjude marvinjude merged commit a05201e into master Aug 18, 2022
@marvinjude marvinjude deleted the dont-break-if-head-has-root-text-node branch August 18, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants