Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-transformer-csv): Fix high memory consumption #36610

Merged
merged 3 commits into from
Nov 16, 2022
Merged

fix(gatsby-transformer-csv): Fix high memory consumption #36610

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
460a425
fix(gatsby-transformer-csv): Fix high memory consumption
Sep 7, 2022
b757784
Merge remote-tracking branch 'upstream/master' into fix/gatsby-transf…
Sep 14, 2022
35e8a11
Merge branch 'master' into fix/gatsby-transformer-csv
LekoArts Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/gatsby-transformer-csv/src/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ async function onCreateNode(
}

// Generate the new node
function transformObject(obj, i) {
async function transformObject(obj, i) {
const csvNode = {
...obj,
id:
Expand All @@ -59,21 +59,22 @@ async function onCreateNode(
},
}

createNode(csvNode)
await createNode(csvNode)
createParentChildLink({ parent: node, child: csvNode })
}

if (_.isArray(parsedContent)) {
if (pluginOptions && nodePerFile) {
if (pluginOptions && _.isString(nodePerFile)) {
transformObject({ [nodePerFile]: parsedContent }, 0)
await transformObject({ [nodePerFile]: parsedContent }, 0)
} else {
transformObject({ items: parsedContent }, 0)
await transformObject({ items: parsedContent }, 0)
}
} else {
_.each(parsedContent, (obj, i) => {
transformObject(obj, i)
})
for (let i = 0, l = parsedContent.length; i < l; i++) {
const obj = parsedContent[i]
await transformObject(obj, i)
}
}
}

Expand Down