-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-page-creator): update pages when nodes change #36623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
label
Sep 16, 2022
pieh
added
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
topic: data
Relates to source-nodes, internal-data-bridge, and node creation
topic: DX
Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
and removed
status: triage needed
Issue or pull request that need to be triaged and assigned to a reviewer
labels
Sep 16, 2022
pieh
force-pushed
the
fix-create-or-delete-pages-on-node-change
branch
2 times, most recently
from
September 17, 2022 09:04
8fe5aa8
to
0968754
Compare
pieh
force-pushed
the
fix-create-or-delete-pages-on-node-change
branch
from
September 19, 2022 11:10
2df7c78
to
208d2e6
Compare
pieh
commented
Sep 19, 2022
packages/gatsby-plugin-page-creator/src/create-pages-from-changed-nodes.ts
Outdated
Show resolved
Hide resolved
pieh
commented
Sep 19, 2022
packages/gatsby-plugin-page-creator/src/create-pages-from-changed-nodes.ts
Outdated
Show resolved
Hide resolved
pieh
force-pushed
the
fix-create-or-delete-pages-on-node-change
branch
from
September 20, 2022 11:49
cadd607
to
051fd2b
Compare
LekoArts
reviewed
Sep 20, 2022
packages/gatsby-plugin-page-creator/src/create-pages-from-changed-nodes.ts
Outdated
Show resolved
Hide resolved
packages/gatsby-plugin-page-creator/src/create-pages-from-collection-builder.ts
Outdated
Show resolved
Hide resolved
…ged-nodes.ts Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
…ection-builder.ts Co-authored-by: Lennart <lekoarts@gmail.com>
LekoArts
approved these changes
Sep 20, 2022
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Sep 28, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 7, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker
added a commit
to dnbexperience/eufemia
that referenced
this pull request
Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well. Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: core
Relates to Gatsby's core (e.g. page loading, reporter, state machine)
topic: data
Relates to source-nodes, internal-data-bridge, and node creation
topic: DX
Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds tracking and updating page state as data changes happen.
TODO:
Related Issues
[ch54038]
fixes #36090