Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-page-creator): update pages when nodes change #36623

Merged
merged 15 commits into from
Sep 21, 2022

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Sep 16, 2022

Description

This adds tracking and updating page state as data changes happen.

TODO:

  • handle node updates (currently it just create pages for completely new nodes or delete pages when node is deleted)
  • add e2e/dev-runtime test cases

Related Issues

[ch54038]
fixes #36090

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 16, 2022
@pieh pieh marked this pull request as draft September 16, 2022 13:22
@pieh pieh added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: data Relates to source-nodes, internal-data-bridge, and node creation topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 16, 2022
@pieh pieh force-pushed the fix-create-or-delete-pages-on-node-change branch 2 times, most recently from 8fe5aa8 to 0968754 Compare September 17, 2022 09:04
@pieh pieh force-pushed the fix-create-or-delete-pages-on-node-change branch from 2df7c78 to 208d2e6 Compare September 19, 2022 11:10
@pieh pieh marked this pull request as ready for review September 19, 2022 11:44
@pieh pieh marked this pull request as draft September 19, 2022 13:38
@pieh pieh force-pushed the fix-create-or-delete-pages-on-node-change branch from cadd607 to 051fd2b Compare September 20, 2022 11:49
@pieh pieh marked this pull request as ready for review September 20, 2022 13:05
pieh and others added 5 commits September 20, 2022 15:31
…ged-nodes.ts

Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
Co-authored-by: Lennart <lekoarts@gmail.com>
…ection-builder.ts

Co-authored-by: Lennart <lekoarts@gmail.com>
@LekoArts LekoArts merged commit d302879 into master Sep 21, 2022
@LekoArts LekoArts deleted the fix-create-or-delete-pages-on-node-change branch September 21, 2022 11:54
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Sep 28, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 4, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 7, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 10, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
tujoworker added a commit to dnbexperience/eufemia that referenced this pull request Oct 11, 2022
Because of this [fix](gatsbyjs/gatsby#36623) which I think if have seen happening in our Portal as well.

Run lint with NODE_ENV=test to prevent babel parsing error (because of babel config change it gets picket up now)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) topic: data Relates to source-nodes, internal-data-bridge, and node creation topic: DX Developer Experience (e.g. Fast Refresh, i18n, SSR, page creation, starters)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File System Collection Routes don't update on changes to data
3 participants