Uuidv5 v1 #3683
Uuidv5 v1 #3683
Conversation
ghost
assigned 
|
Deploy preview for gatsbygram ready! Built with commit 3877b5f |
| @@ -76,6 +77,7 @@ const runAPI = (plugin, api, args) => { | |||
| reporter, | |||
| getNodeAndSavePathDependency, | |||
| cache, | |||
| createNodeId, | |||
There was a problem hiding this comment.
I can't remember if we talked about this but we should automatically set the namespace for each plugin using its name. That way there's no chance that ids could clash.
There was a problem hiding this comment.
Oh, that was mentioned before, yeah. Obviously not here yet, but I'll add it quick.
There was a problem hiding this comment.
Ha, actually it was half here, the method takes a namespace, just wasn't setting that up properly.
|
Awesome, thanks! |
|
Oh, could you update the snapshots so Travis passes? |
|
Pushed. Sorry, my test suite was fairly broken(I hadn't run bootstrap recently) and I didn't realize that was keeping the wordpress snapshot from updating. |
|
nice, thanks! |
|
Can we define in plugins package.json what version of gatsby they rely on? (my package.json dependencies knowledge is weak) For context #3787 |
|
@pieh yeah we're adding Gatsby as a |
This is targeted at
masterand makes the UUID creation a helper method that gets passed along to pluginsrefs #1853