Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Field inferring changes and cleanup #3688

Merged
merged 12 commits into from
Feb 9, 2018
Merged

Field inferring changes and cleanup #3688

merged 12 commits into from
Feb 9, 2018

Commits on Jan 25, 2018

  1. remove not needed edge case for infering array of objects to improve … 

    …code readability
    @pieh
    pieh committed Jan 25, 2018
    Configuration menu
    Copy the full SHA
    c6c7afa View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2018

  1. don't lose field args and resolve function when infering array (fixes… 

    … date format options not available in arrays of dates)
    @pieh
    pieh committed Jan 26, 2018
    Configuration menu
    Copy the full SHA
    e824161 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2018

  1. move infering date field to seperate file to improve code readability

    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    b17b398 View commit details
    Browse the repository at this point in the history

  2. don't recreate date field definition for every date field - we can re… 

    …use same object
    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    0f8e40b View commit details
    Browse the repository at this point in the history

  3. create dedicated Date graphql scalar (based on string scalar) for dat… 

    …e fields
    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    e206186 View commit details
    Browse the repository at this point in the history

  4. pass fieldName to resolver when filtering on types with custom resolv… 

    …ers (date type fields now rely on fieldname info being passed)
    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    ced9eb3 View commit details
    Browse the repository at this point in the history

  5. use already constructed nextselector instead of rebuilding it again

    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    19ef16d View commit details
    Browse the repository at this point in the history

  6. move infering file field to separate file to improve code readability

    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    9e3cb58 View commit details
    Browse the repository at this point in the history

  7. create file type field object just once and reuse it

    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    6112cc1 View commit details
    Browse the repository at this point in the history

  8. move trying to infer Files from string paths to inferGraphQLType func… 

    …tion where rest of value based inferring is done
    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    5bb3da5 View commit details
    Browse the repository at this point in the history

  9. add tests for inferring File from string paths

    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    2e18f75 View commit details
    Browse the repository at this point in the history

  10. add tests for inferring date type from string, array of strings and f… 

    …iltering date fields, move date related test to seperate date test suite
    @pieh
    pieh committed Jan 28, 2018
    Configuration menu
    Copy the full SHA
    b9fe96d View commit details
    Browse the repository at this point in the history