Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-link): Correct type export #36968

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

roryclaasen
Copy link
Contributor

Description

Since the merge of #36888, gatsby-link is no longer exporting the type as default, typescript no longer provides typings for Link components.
Currently the gatsby package is exporting Link but there is no type for it defined in index.d.ts in gatsby-link only GatsbyLink.
As this is only a typing issue, the use of the component is working fine, but there is no intellisense support.

This PR renames the GatsbyLink type definition to Link to resolve this issue.

Documentation

Shouldn't need any mention or update in docs.

Related Issues

Related to PR #36888

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 4, 2022
@LekoArts LekoArts added topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 7, 2022
@LekoArts LekoArts changed the title Fixes gatsby-link Link type export chore(gatsby-link): Correct type export Nov 7, 2022
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 6a53861 into gatsbyjs:master Nov 7, 2022
@roryclaasen roryclaasen deleted the fix/link-export branch November 7, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: TypeScript Issues and PRs related to TS in general, public typings or gatsby-plugin-typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants