-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update .gitpod
to use correct Node version
#37336
chore: Update .gitpod
to use correct Node version
#37336
Conversation
Hi, thanks for the PR! The repository already contains a |
Unfortunately, without the explicit installation, that results in:
I will update the Dockerfile to bring in the I've confirmed this is working as expected locally using the VSCode Devcontainer feature. {
"name": "Existing Dockerfile",
"build": {
"context": "..",
"dockerfile": "../.gitpod.Dockerfile"
}
} |
.gitpod
to use correct Node version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR as-is looks good to me.
I think the dev container thingy is a separate discussion. From my testing with GitHub codespaces the repository just worked, it didn't have the niceties installed like the gitpod version though.
I'm open for adding a devcontainer config (https://docs.github.com/en/codespaces/setting-up-your-project-for-codespaces/setting-up-your-project-for-codespaces) but let's do that in another PR :)
Description
Update Gitpod to use node version 18.
Added commands according to Gitpod documentation, except updated bash var to
NODE_VERSION
instead of the more genericVERSION
suggested.Documentation
N/A - this just allows the current gitpod config to run correctly.
Related Issues
N/A - I haven't created any separate issues for this.
Currently, opening the repo in Gitpod, or locally as a container in VSCode, yields the following error: