Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Restore asset, path prefix for file-loader handled files #37429

Merged
merged 3 commits into from
Jan 10, 2023
Merged

fix(gatsby): Restore asset, path prefix for file-loader handled files #37429

merged 3 commits into from
Jan 10, 2023

Conversation

tyhopp
Copy link
Contributor

@tyhopp tyhopp commented Jan 10, 2023 •
edited
Loading

Description

In #37284 we stopped duplicate output of files, but also removed the ability to set assetPrefix and pathPrefix for files handled by file-loader. This change restores that functionality.

Documentation

N/A

Related Issues

Fixes #37427

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jan 10, 2023
@tyhopp tyhopp added topic: render-mode Related to Gatsby's different rendering modes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jan 10, 2023
@tyhopp tyhopp changed the title fix(gatsby): Preserve asset, path prefix fix(gatsby): Restore asset, path prefix Jan 10, 2023
@tyhopp tyhopp changed the title fix(gatsby): Restore asset, path prefix fix(gatsby): Restore asset, path prefix for file-loader handled files Jan 10, 2023
@tyhopp tyhopp marked this pull request as ready for review January 10, 2023 04:28
LekoArts
LekoArts approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tests, nice!

@LekoArts LekoArts merged commit b0c0913 into master Jan 10, 2023
@LekoArts LekoArts deleted the fix/path-and-asset-prefix branch January 10, 2023 07:08
@gatsbybot gatsbybot mentioned this pull request Jan 10, 2023
Merged
LekoArts pushed a commit that referenced this pull request Jan 10, 2023
@tyhopp @LekoArts
fix(gatsby): Restore asset, path prefix for file-loader handled files (…
0715286 
…#37429)

(cherry picked from commit b0c0913)
LekoArts pushed a commit that referenced this pull request Jan 10, 2023
@gatsbybot @tyhopp
fix(gatsby): Restore asset, path prefix for file-loader handled files (…
e2084f6 
…#37429) (#37430)

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
This was referenced Jan 10, 2023
Open
Open
Open
Open
Open
Open
Open
@ajesse11x ajesse11x mentioned this pull request Jan 10, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 10, 2023
Open
@Rutam21 Rutam21 mentioned this pull request Jan 10, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 10, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jan 10, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jan 11, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Jan 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2023
Open
@0xSebin 0xSebin mentioned this pull request Jan 12, 2023
Open
This was referenced Jan 12, 2023
Open
Open
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 12, 2023
Open
@kaocher82 kaocher82 mentioned this pull request Jan 13, 2023
Open
@monizb monizb mentioned this pull request Feb 16, 2023
Open
@pieh pieh mentioned this pull request Feb 16, 2023
Closed
2 tasks
This was referenced Feb 16, 2023
Merged
Merged
This was referenced Feb 18, 2023
Open
Open
This was referenced Apr 24, 2023
Open
Open
Open
Open
@monizb monizb mentioned this pull request May 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 25, 2023
Open
@monizb monizb mentioned this pull request May 25, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2023
Open
pastepi pushed a commit to pastepi/gatsby that referenced this pull request Dec 16, 2023
@tyhopp @pastepi
fix(gatsby): Restore asset, path prefix for file-loader handled files (…
afb2af9 
…gatsbyjs#37429)
@pastepi pastepi mentioned this pull request Dec 16, 2023
Merged
pieh pushed a commit that referenced this pull request Dec 19, 2023
@pastepi @tyhopp
fix(gatsby): Restore asset, path prefix for file-loader handled files (…
5ea513c 
…#38764)

* fix(gatsby): Restore asset, path prefix for file-loader handled files (#37429)

* add missing import, read vars from config

---------

Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
topic: render-mode Related to Gatsby's different rendering modes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image URLs from file loader no longer have asset prefix in 5.3.3
2 participants
@tyhopp @LekoArts