fix(gatsby-source-wordpress): prevent inconsistent schema customization #37749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
TylerBarnes
added
topic: source-wordpress
…thub.com/gatsbyjs/gatsby into fix/wp-inconsistent-schema-customization
kathmbeck
previously approved these changes
Mar 16, 2023
TylerBarnes
added
the
bot: merge on green
pieh
added a commit
that referenced
this pull request
Mar 30, 2023
…on (#37749) (#37778) * fix(gatsby-source-wordpress): prevent inconsistent schema customization (#37749) * panic or warn when schema customization is inconsistent * ensure types are always properly excluded * add blocklist of typename parts which cause a type to be excluded if it's name includes a part (cherry picked from commit 9f26b67) * ignore browserlist update prompt * fix ignore * fix(gatsby-source-wordpress): Force removal of types (#37424) --------- Co-authored-by: Tyler Barnes <tylerdbarnes@gmail.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37729
Canary available as
gatsby-source-wordpress@7.8.0-alpha-wp-inconsistent-schema.29The problem here was
source-wordpresswas only excluding some problematic types on initial builds and then re-including them on cached builds. This wasn't a problem before but due to a change in WPGraphQL 1.14.0 this ended up producing an invalid schema which would fail builds.In order to figure out what was going wrong I had to write some code that diffed the built schema customization types and outputted a warning. Since it was pretty useful I ended up keeping that warning in for
gatsby developso we can catch these kinds of problems in the future if they occur again for some other reason.I also removed some types from snapshots because those types are newly excluded. I excluded them because they're just connection types to previously excluded types and I don't want them to cause problems in the future.