feat:(gatsby-cli) - support REACT_PROFILE env var value to set profile cli argument #37754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: cli
pieh
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It currently does not look like there's a way to enable React profiling other than passing the cli argument
--profile. This PR adds support for aREACT_PROFILEenv var to set that flag in situations where the flag cannot be passed, such as with builds on Gatsby Cloud.Documentation
Before merging and releasing this change, I would want to update documentation in two places:
Tests
I need to determine how to test this. I don't see any relevant unit tests. And I'm not sure how to go about testing this change absent of using
patch-package/ locally adjustinggatsbyin mynode_modulesfor a site.Related Issues
N/A