fix(create-gatsby): Use correct name in summary message #37809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: cli
pieh
approved these changes
Mar 30, 2023
TylerBarnes
pushed a commit
that referenced
this pull request
Mar 30, 2023
* actual fix * other misc changes
pieh
added a commit
that referenced
this pull request
Apr 18, 2023
* add touch nodes optout action * cleanup * start adding backreference cache * revert formatting * remove unused variable * remove unused var * switch from opting out types from stale nodes to opting out entire plugin * add no nodes warning * fix bug where double bound actions are ignored when there are no args * update progress mock * get owner from plugin * rename type * rename types * use redux types instead of pulling from lmdb * remove unused line * Update source-nodes.ts * use CREATE_NODE action instead of adding a new type owner action * add typeowners test * test touchNodes and enableStatefulSourceNodes() * fix contentful tests * snapshot updates * chore(changelogs): update changelogs (#37808) * fix(deps): update starters and examples - gatsby to ^5.8.1 (#37806) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(gatsby): Validate sub plugins options (#37804) * fix(gatsby): validate sub plugins options of gatsby-plugin-mdx * revert hardcoded path to subplugins * validate subplugins if they are not under 'options.plugins' field --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * fix(create-gatsby): Use correct name in summary message (#37809) * actual fix * other misc changes * chore(release): Publish next - create-gatsby@3.9.0-next.1 - gatsby-cli@5.9.0-next.1 - gatsby-plugin-sharp@5.9.0-next.1 - gatsby-transformer-sqip@5.9.0-next.1 - gatsby@5.9.0-next.2 * remove testing timeout * minimal docs * reword * add comment * reportOnce instead of throwing an error * consolidate typeOwners * use new typesToPlugins Map keys instead of pluginsToTypes Map values * consolidate remaining typeOwners object checks into new typeOwners reducer * fix missing owner error * fix type errors and incorrect plugin object reference * maybe fix unit tests * make SitePage nodes owned by internal-data-bridge * add missing fields on some TOUCH_NODE actions * skip owner checks when deleting child nodes * sp * Update yarn.lock * reduce memory usage by storing minimal backreference info and not blocking the event loop * remove coment * remove extra logs * add helper to explain what the setImmediate promise is for * remove unneeded entryNode condition * refactor createAssetNodes to use async/await * add cached node counts by assets vs content * refactor to fix linting failure * fix tests * ensure mutated existing node data is applied during updates * restore previous logging behaviour * fix test state * always reset memory node count when existingNodes is empty * revert more logging * update test to use new createAssetNodes changes * store count instead of huge set of id's to use less memory * remove debugger * make sure sys.type exists before checking * move enableStatefulSourceNodes call to main sourceNodes fn * use util * fix e2e test - ContentfulTag node doesn't have sys.type * always exclude ContentfulTag nodes from memory Map cache * fix linting (consistent return) --------- Co-authored-by: GatsbyJS Bot <core-team@gatsbyjs.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Taozc <41264828+Talaxy009@users.noreply.github.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> Co-authored-by: Lennart <lekoarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
siteNameinside the summary message instead ofdirName.Also removed an unnecessary
anyTS type assertion and updated a docs link.Tests
I did run the CLI with the changes applied locally. It now looks like this:
➜ node ../work/gatsby/packages/create-gatsby/cli.js create-gatsby version 3.9.0-next.0 Welcome to Gatsby! This command will generate a new Gatsby site for you in /Users/lejoe/code/playground with the setup you select. Let's answer some questions: What would you like to call your site? ✔ · My Gatsby Site What would you like to name the folder where your site will be created? ✔ playground/ my-gatsby-site ✔ Will you be using JavaScript or TypeScript? · JavaScript ✔ Will you be using a CMS? · No (or I'll add it later) ✔ Would you like to install a styling system? · No (or I'll add it later) ✔ Would you like to install additional features with other plugins?No items were selected Thanks! Here's what we'll now do: 🛠 Create a new Gatsby site in the folder my-gatsby-site ✔ Shall we do this? (Y/n) · Yes ✔ Created site from template ❯ Installing Gatsby... ✔ Installed plugins ✔ Created site in my-gatsby-site 🎉 Your new Gatsby site My Gatsby Site has been successfully created at /Users/lejoe/code/playground/my-gatsby-site. Start by going to the directory with cd my-gatsby-site Start the local development server with yarn develop See all commands at https://www.gatsbyjs.com/docs/reference/gatsby-cli/Related Issues
Fixes #37718