Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): support multiple instances of same variable in gatsbyImage placeholderUrl #38626

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

cunhacf
Copy link
Contributor

@cunhacf cunhacf commented Oct 10, 2023

Description

Fixes a bug where multiple instances of variables in gatsbyImage's placeholderUrl are only replaced once.

Tests

Tested locally.

Related Issues

Fixes #38604

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 10, 2023
@pieh pieh added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 20, 2023
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, thanks!

@pieh pieh merged commit b177db9 into gatsbyjs:master Oct 20, 2023
33 checks passed
pieh pushed a commit that referenced this pull request Oct 20, 2023
pieh pushed a commit that referenced this pull request Oct 20, 2023
…ge placeholderUrl (#38626) (#38647)

(cherry picked from commit b177db9)

Co-authored-by: Carlos Fernandes Cunha <cunhacf@users.noreply.github.com>
@pieh
Copy link
Contributor

pieh commented Oct 20, 2023

gatsby-plugin-utils@4.12.2 was released with this fix

This was referenced Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
Status: Published
Development

Successfully merging this pull request may close these issues.

placeholderUrl variables only get replaced once
2 participants