fix: respect 'force' and 'conditions' properties on redirects #38657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
jenae-janzen
changed the title
pieh
changed the title
pieh
added
topic: adapters
pieh
pushed a commit
that referenced
this pull request
Oct 25, 2023
* move force redirects changes to main repo * empty commit * fix: conditions and add e2e test case * test: fix country condition assertion --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit 48d311e)
pieh
pushed a commit
that referenced
this pull request
Oct 26, 2023
#38664) * move force redirects changes to main repo * empty commit * fix: conditions and add e2e test case * test: fix country condition assertion --------- Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit 48d311e) Co-authored-by: Jenae Janzen <101715009+jenae-janzen@users.noreply.github.com>
This was referenced Nov 17, 2023
This was referenced Dec 22, 2023
This was referenced Dec 29, 2023
This was referenced Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Moved from #38640)
https://linear.app/netlify/issue/FRA-19/force-is-not-honoured
https://linear.app/netlify/issue/FRA-21/conditions-on-redirects-are-not-honoured
When a redirect is created, it can accept a force parameter that can trigger the redirect even if the fromPath matches a piece of content. However, this functionality isn't working with the Adapter, possibly because the parameter isn't being passed along into the routes handler.
Description
Documentation
Tests
Related Issues