Fix type of navigate method #39169
Merged
Fix type of navigate method #39169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of the original navigation function type created problems when using spreaded parameters. Since the navigate implementation in gatsby does not have the same call signature as @reach/router anyways (the promise returned by @reach/router is ignored), it is easier to define our own interface than to overwrite the types from @reach/router.
gatsbot
bot
added
the
status: triage needed
|
@pieh does it matter that most tests fail? These are not related to the fix. |
|
Would love to see this merged as this is currently blocking me from updating Gatsby. |
serhalp
approved these changes
Dec 16, 2024
Comment on lines
-36
to
+39
| export const navigate: (...args: Parameters<NavigateFn>) => void; | ||
| export const navigate: { | ||
| (to: string, options?: NavigateOptions<{}>): void | ||
| (to: number): void | ||
| } |
There was a problem hiding this comment.
serhalp
added
status: accepted
and removed
status: triage needed
|
Published: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The usage of the original navigation function type created problems when using spreaded parameters. Since the navigate implementation in gatsby does not have the same call signature as @reach/router anyways (the promise returned by @reach/router is ignored), it is easier to define our own interface than to overwrite the types from @reach/router.
Related Issues
Fixes #39158