Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with resolving local plugins #4275

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

tsriram
Copy link
Contributor

@tsriram tsriram commented Feb 28, 2018

Fixes #4274

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 5a3c80e

https://deploy-preview-4275--gatsbygram.netlify.com

@KyleAMathews KyleAMathews merged commit c5ed4ae into gatsbyjs:master Feb 28, 2018
@ghost ghost removed the review label Feb 28, 2018
@KyleAMathews
Copy link
Contributor

Thanks!

m-allanson referenced this pull request Feb 28, 2018
* Warn when replaceRenderer is implemented multiple times

* Remove unused import

* Add tests

* Back out 'named arguments' change from apiRunner

* Re-add required import

* Add first draft of docs page

* Simplify language based on results from Hemingway App

See http://www.hemingwayapp.com/

* Implement docs feedback

* Capitalisation

* Copy tweaks

* More concise 'add internal plugins'

* Use work from previous PR's to improve this

- remove duplicate error messages
- improve message format
- only run the last replaceRenderer plugin

* Remove unused import

* Use the reporter for nicer error formatting

* Exit on error during build

* Split code out into smaller functions and add tests

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants