add extract-text-webpack-plugin helper package #4532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
erquhart
force-pushed
the
add-extract-plugin-helper
branch
from
5945d98
to
09ca5aa
Compare
|
Deploy preview for gatsbygram ready! Built with commit 5945d98 |
|
Deploy preview for gatsbygram ready! Built with commit 99ef02c |
|
Deploy preview for using-drupal ready! Built with commit 5945d98 |
|
Deploy preview for using-drupal ready! Built with commit 99ef02c |
erquhart
force-pushed
the
add-extract-plugin-helper
branch
2 times, most recently
from
438fb46
to
3947e8d
Compare
erquhart
force-pushed
the
add-extract-plugin-helper
branch
from
3947e8d
to
99ef02c
Compare
|
@KyleAMathews this PR will include the package for initial publishing, after that I'll put up a PR for implementing it in Gatsby's webpack config and the Sass plugin. We can give that a bit of time in case bugs surface before implementing in the remaining statically extracted style plugins. |
|
Nice! Will merge and publish so you can start on the implementation. Thanks for jumping into this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides shared per-stage
extract-text-webpack-plugininstances for all Gatsby plugins, including Gatsby core (implementation PR will follow). Gatsby styling plugins currently overwrite one another's output during the build whenever multipleextract-text-webpack-plugininstances are added to the Webpack config (the Netlify CMS plugin does this). This happens because the plugins are importingextract-text-webpack-pluginand instantiating a new instance direct from the constructor. The module added by this PR allows all plugins to use the same instance.In short, this enables a simpler and more reliable way to achieve the fix from #4495 for all plugins.
Related to #4516.
Note: the conventions in this PR are borrowed from
gatsby-1-config-css-moduleswith the assumption that that package is a desirable pattern for Gatsby config helpers.