Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hash anchor scrolling #467

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Fixed hash anchor scrolling #467

merged 1 commit into from
Sep 26, 2016

Conversation

f0rr0
Copy link

@f0rr0 f0rr0 commented Sep 26, 2016

Fixes #462

@KyleAMathews
Copy link
Contributor

This is great! Thanks for tracking down the problem and fixing it! Could you land the same change on the 1.0 branch?

It'd be on both https://github.com/gatsbyjs/gatsby/blob/1.0/lib/intermediate-representation-dir/production-app.js and https://github.com/gatsbyjs/gatsby/blob/1.0/lib/intermediate-representation-dir/root.js (root.js needs renamed but it's the development web-entry.js basically.)

@KyleAMathews KyleAMathews merged commit 908db1e into gatsbyjs:master Sep 26, 2016
@f0rr0
Copy link
Author

f0rr0 commented Sep 26, 2016

@KyleAMathews Anytime! Opened a PR for the 1.0 branch. It'll be great if you could cut a new release from master though.

@f0rr0
Copy link
Author

f0rr0 commented Sep 27, 2016

It's worth noting that the back button scrolling will not work for hash anchors on the same page. Could cause confusion for someone.

@jlengstorf
Copy link
Contributor

Hiya @f0rr0! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants