Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native-web example #4885

Merged
merged 2 commits into from
Apr 14, 2018

Conversation

slorber
Copy link
Contributor

@slorber slorber commented Apr 7, 2018

@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 8db6089

https://deploy-preview-4885--using-drupal.netlify.com

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @slorber!

@KyleAMathews KyleAMathews merged commit 036b3c8 into gatsbyjs:master Apr 14, 2018
@KyleAMathews
Copy link
Contributor

Thanks!

@slorber
Copy link
Contributor Author

slorber commented Apr 16, 2018

thank you too :)

"gatsby-plugin-react-next": "^1.0.11",
"react": "^16.2.0",
"react-dom": "^16.2.0",
"react-native-web": "^0.5.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this example to use 0.6.x and the latest version of the gatsby-plugin-react-native-web now that its using the latest APIs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure @necolas I just need the changes required to Gatsby to be commited first. I'm in a cyclic dependency problem as I need Gatsby to publish change, so that plugin can be republished, so that example in Gatsby can be updated.

The plugin version I published temporarily was deprecated as I was asked to rename the new Gatsby method and it's not merged yet. I'll make sure the sample use the new plugin version as soon as I can

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for this PR to be merged: #5017

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slorber with the core/plugin updated, lemme know when this is ready to go in 🎉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KyleAMathews I'm sorry I won't have time to do that, it's on my todo for next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants