Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use index within container #5029

Merged
merged 2 commits into from
Apr 24, 2018
Merged

Use index within container #5029

merged 2 commits into from
Apr 24, 2018

Conversation

skube
Copy link
Contributor

@skube skube commented Apr 18, 2018

Confusing as to what is being asked. Later, the docs say to import Container from "../components/container";

Confusing as to what is being asked. Later, the docs say to `import Container from "../components/container";`
@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 18, 2018

Deploy preview for using-drupal ready!

Built with commit f049497

https://deploy-preview-5029--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

gatsbybot commented Apr 18, 2018

Deploy preview for gatsbygram ready!

Built with commit f049497

https://deploy-preview-5029--gatsbygram.netlify.com

@m-allanson
Copy link
Contributor

Thanks @skube!

I wonder if this could be simplified.. with your change the path to the file will be:

src/components/container/index.js

which will work, but I think it should be:

src/components/container.js

So maybe the language could be changed to match how directories are created earlier in the tutorial. Would this be clear?

Create a new directory at src/components and then, in this directory, create a file named container.js and paste the following:

Copy link
Contributor Author

@skube skube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are suggested

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @skube!

@m-allanson m-allanson merged commit 4c9f6e2 into gatsbyjs:master Apr 24, 2018
@skube
Copy link
Contributor Author

skube commented Apr 24, 2018

Thanks @m-allanson 🕺🏻

@jlengstorf
Copy link
Contributor

Hiya @skube! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants