Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] fix pathPrefix #5178

Merged
merged 1 commit into from
Apr 30, 2018
Merged

[v2] fix pathPrefix #5178

merged 1 commit into from
Apr 30, 2018

Conversation

nihgwu
Copy link
Contributor

@nihgwu nihgwu commented Apr 29, 2018

No description provided.

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nihgwu!

Were you seeing an error before this change?

@nihgwu
Copy link
Contributor Author

nihgwu commented Apr 30, 2018

@m-allanson sure, when I build with prefix-paths, the loading path of some JSON files are wrong

@nihgwu
Copy link
Contributor Author

nihgwu commented Apr 30, 2018

BTW, I still can't make my site up after upgrade to latest gatsby v2 with prefix-paths enabled, I've managed to solve several issues already

@KyleAMathews KyleAMathews merged commit 841ab89 into gatsbyjs:v2 Apr 30, 2018
@KyleAMathews
Copy link
Contributor

Thanks for the fixes :-)

@nihgwu nihgwu deleted the neo/fix-pathPrefix branch April 30, 2018 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants