Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve deprecation notices during development #5185

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

jlengstorf
Copy link
Contributor

This update tells developers the new name of the deprecated props to make it easier to upgrade.

re #3986

This update tells developers the new name of the deprecated props to make it easier to upgrade.

re gatsbyjs#3986
@jlengstorf
Copy link
Contributor Author

jlengstorf commented Apr 29, 2018

Any ideas what caused this failure in Travis or how to fix it?

$ babel-node scripts/check-versions.js
gatsby-source-drupal: 
  Depends on "gatsby-source-filesystem@next" 
  instead of "gatsby-source-filesystem@2.0.0-alpha.8". 
gatsby-source-wordpress: 
  Depends on "gatsby-source-filesystem@next" 
  instead of "gatsby-source-filesystem@2.0.0-alpha.8". 

@jlengstorf
Copy link
Contributor Author

This is what the updated errors look like, by the way.

screen shot 2018-04-29 at 12 35 31 pm

@pieh
Copy link
Contributor

pieh commented Apr 29, 2018

I've caused check-version failure in Travis ( #5170 - context for that ), but test weren't passing either way on v2. Will look into fixing that particular thing tomorrow

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @jlengstorf.

@m-allanson m-allanson merged commit f2c205c into gatsbyjs:v2 Apr 30, 2018
@jlengstorf jlengstorf deleted the v2-improve-deprecation-notices branch April 30, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants